On Sun, Jun 25, 2023 at 12:33 AM Krzysztof Wilczyński <kw@xxxxxxxxx> wrote: > > [1/1] PCI: vmd: Fix uninitialized variable usage in vmd_enable_domain() > https://git.kernel.org/pci/pci/c/0c0206dc4f5b > > > PCI: vmd: Clean up one inconsistent indenting warn reported by Smatch > > Even though this is a very nice clean-up, I did not take this patch at this > time, as there has been a similar patch posted in the past, and Christoph > Hellwig suggested, as part of his review, an alternative approach worth > considering. > > Have a look at the following and let me know what you think: > > https://patchwork.kernel.org/project/linux-pci/patch/20221115054847.77829-1-jiapeng.chong@xxxxxxxxxxxxxxxxx/ I think Christoph Hellwig's suggestion is indeed better. So, should I submit a new patch to address this issue? Thanks～
