Hello, > this series adapts the platform drivers below drivers/pci to use the > .remove_new() callback. Compared to the traditional .remove() callback > .remove_new() returns no value. This is a good thing because the driver core > doesn't (and cannot) cope for errors during remove. The only effect of a > non-zero return value in .remove() is that the driver core emits a warning. The > device is removed anyhow and an early return from .remove() usually yields a > resource leak. > > By changing the remove callback to return void driver authors cannot > reasonably assume any more that there is some kind of cleanup later. > > All drivers were easy to convert as they all returned zero in their > remove callback. Only for iproc the conversion wasn't trivial, the other > were converted using coccinelle. > > There are no interdependencies between these patches. So even if there > are some concerns for individual patches, I ask you to apply the > remaining set. Then I only have to care for the review feedback of the > refused patches. (Having said that I don't expect any serious objection, > just things like squashing or separating patches, or maybe I picked a > wrong subject prefix.) Applied to controller/remove-void-callbacks, thank you! [01/15] PCI: aardvark: Convert to platform remove callback returning void https://git.kernel.org/pci/pci/c/b11c76db97e7 [02/15] PCI: altera: Convert to platform remove callback returning void https://git.kernel.org/pci/pci/c/3a610560aa4f [03/15] PCI: altera-msi: Convert to platform remove callback returning void https://git.kernel.org/pci/pci/c/60d03f70455c [04/15] PCI: brcmstb: Convert to platform remove callback returning void https://git.kernel.org/pci/pci/c/b169c576ad0c [05/15] PCI: j721e: Convert to platform remove callback returning void https://git.kernel.org/pci/pci/c/c86f4bd6008e [06/15] PCI: dwc: Convert to platform remove callback returning void https://git.kernel.org/pci/pci/c/221879c98698 [07/15] PCI: hisi-error: Convert to platform remove callback returning void https://git.kernel.org/pci/pci/c/9a285fbbb591 [08/15] PCI: iproc: Convert to platform remove callback returning void https://git.kernel.org/pci/pci/c/6f1c0a046048 [09/15] PCI: mediatek: Convert to platform remove callback returning void https://git.kernel.org/pci/pci/c/5e0005409427 [10/15] PCI: mediatek-gen3: Convert to platform remove callback returning void https://git.kernel.org/pci/pci/c/22626c46bb32 [11/15] PCI: mt7621: Convert to platform remove callback returning void https://git.kernel.org/pci/pci/c/8c47ac2a66c4 [12/15] PCI: mvebu: Convert to platform remove callback returning void https://git.kernel.org/pci/pci/c/4c3bc1b41b8f [13/15] PCI: rockchip-host: Convert to platform remove callback returning void https://git.kernel.org/pci/pci/c/2998efcd8e73 [14/15] PCI: tegra: Convert to platform remove callback returning void https://git.kernel.org/pci/pci/c/c7fd95cda648 [15/15] PCI: xgene-msi: Convert to platform remove callback returning void https://git.kernel.org/pci/pci/c/afbb9130d2bf Krzysztof