Hello Daire, On Wed, Jun 14, 2023 at 04:55:51PM +0100, daire.mcnamara@xxxxxxxxxxxxx wrote: > From: Daire McNamara <daire.mcnamara@xxxxxxxxxxxxx> > > Enable building this driver as a module. The expected use case is the > driver is built as a module, is installed when needed, and cannot be > removed once installed. > > The remove() callback is not implemented as removing a driver with > INTx and MSI interrupt handling is inherently unsafe. The relevant thing here is not that there is no .remove callback (which doesn't make the driver non-removable) but that the driver has .suppress_bind_attrs = true. With that properly mentioned in the changelog, the patch is fine for me. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
