On Sun, Mar 4, 2012 at 7:54 PM, Olof Johansson <olof@xxxxxxxxx> wrote: > On Thu, Feb 23, 2012 at 08:41:39AM +1100, Benjamin Herrenschmidt wrote: >> On Wed, 2012-02-22 at 11:19 -0700, Bjorn Helgaas wrote: >> > int maple_pci_get_legacy_ide_irq(struct pci_dev *pdev, int channel) >> > diff --git a/arch/powerpc/platforms/pasemi/pci.c >> > b/arch/powerpc/platforms/pasemi/pci.c >> > index b6a0ec4..b27d886 100644 >> > --- a/arch/powerpc/platforms/pasemi/pci.c >> > +++ b/arch/powerpc/platforms/pasemi/pci.c >> > @@ -231,7 +231,7 @@ void __init pas_pci_init(void) >> > pci_devs_phb_init(); >> > >> > /* Use the common resource allocation mechanism */ >> > - pci_probe_only = 1; >> > + pci_add_flags(PCI_PROBE_ONLY); >> > } >> >> Olof, do you remember why you used to set that on pasemi ? > > Oops, going through email backlog. Sorry for the slow response. > >> I would have expected it to be clear, so the kernel can re-assign things >> if needed. We really only want it set for pseries because of the >> hypervisor being a PITA :-) > > Well, we did have some hypervisor work done at PA Semi too, and chances > are it's from there. But it's unlikely since I think we booted pseries > (PAPR) kernels under rHype. > > I suspect we just went with it for whatever legacy reasons and didn't > revisit later -- since our firmware enumerated busses reliably there > was no reason to redo it from the kernel. > > I've booted a system with pci_probe_only off here, and it seems happy > enough. I'll send you a patch. > > Bjorn, that means you can drop this chunk of the patch, I suppose. Sorry to comment to myself so quickly but since I just noticed that the patch is in -next, don't worry about rebasing your work -- we'll take out the flag use later. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
