Hi Sui, On Tue, Jun 06, 2023 at 06:27:05PM +0800, Sui Jingfeng wrote: > Hi, > > On 2023/6/6 10:06, Sui Jingfeng wrote: > > Originally, I also want to express the opinion. > > > Originally, I want to express the same opinion as you told me. > > Because vga_iostate_to_str() function is taking unsigned int parameter. > > so, I think, using 'unsigned int *' type as the third parameter > vga_str_to_iostate() function is more suitable. > > > But this patch is too trivial, so I smash them into one patch. it does not matter. Please keep patches separated. A trivial patch can be ignored, however lots of trivial patches in a bigger series might be appreciated. Have fun! Andi