On Fri, Jun 02, 2023 at 02:08:45PM +0100, Ben Dooks wrote: > On 31/05/2023 22:37, Bjorn Helgaas wrote: > > On Wed, May 31, 2023 at 10:57:13AM +0100, Ben Dooks wrote: > > > From: Ben Dooks <ben.dooks@xxxxxxxxxx> > > > > > > Add the define for PCI_EXT_CAP_ID_PL_32GT for drivers that > > > will want this whilst doing Gen5/Gen6 accesses. > > > > > > Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxx> > > > Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx> > > > > I applied this to pci/enumeration for v6.5, thanks. > > > > But I'm very curious about where you expect this to be used. > > We have an upcoming driver that has gen5 phy and config requirements. I guess a better question would have been whether PCI_EXT_CAP_ID_PL_32GT is best used in individual drivers or in the PCI core. Since it's in the PCIe base spec and doesn't look like it should be device-specific, it might be a candidate for supporting in the PCI core somehow so it doesn't get reimplemented in several places. Bjorn
