Re: [PATCH 2/2] x86/PCI: Slightly simplify pirq_convert_irt_table()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 6 May 2023, Christophe JAILLET wrote:

> 'size' if computed twice. *ir and *it being the same, the result is the
> same as well.

 There is no `it' data object in this function; I presume you meant `rt'. 
Then `*ir' and `*rt' are of a different type each, hence the calculations 
are not the same.  If they were the same, the function wouldn't be needed 
at all in the first place.  Therefore, NAK.

> While at it, also use struct_size() which is less verbose, more robust and
> more informative.

 This might be a valuable clean-up, thank you, please submit separately.

  Maciej



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux