Re: [PATCH v4] PCI: pciehp: Fix the slot in BLINKINGON_STATE when Presence Detect Changed event occurred

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 17, 2023 at 04:02:01PM -0500, Bjorn Helgaas wrote:
> I'm curious why we want the 5 seconds of blinking power indicator at
> all.  We can't really do anything in response to an Attention Button
> on an empty slot, so could we just ignore it completely in
> pciehp_handle_button_press()?

That wouldn't cover the case where the slot is occupied when the
button is pressed, but the card is yanked out during the 5 second
blinking interval.

We'd still need the present commit to handle that case.

Thanks,

Lukas



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux