On Fri, May 12, 2023 at 10:15:18AM +0800, Rongguang Wei wrote:
> pciehp's behavior is incorrect if the Attention Button is pressed
> on an unoccupied slot.
[...]
> V2: Update to simple code and avoid gratuitous message.
> V3: Add Suggested-by.
> V4: Add state change conditional and message.
>
> Fixes: d331710ea78f ("PCI: pciehp: Become resilient to missed events")
> Link: https://lore.kernel.org/linux-pci/20230403054619.19163-1-clementwei90@xxxxxxx/
> Link: https://lore.kernel.org/linux-pci/20230421025641.655991-1-clementwei90@xxxxxxx/
The changes from previous versions of the patch as well as the links to
those previous versions are usually placed below the three dashes.
That way they don't become part of the git history as they're generally
not interesting for future readers. (The exception of that rule is the
gpu subsystem which habitually puts the changelog in the commit message.)
However I don't think you need to respin the patch because of that as
Bjorn can fix up the commit message when applying. Just so you know
for future submissions.
> Suggested-by: Lukas Wunner <lukas@xxxxxxxxx>
> Signed-off-by: Rongguang Wei <weirongguang@xxxxxxxxxx>
Reviewed-by: Lukas Wunner <lukas@xxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx # v4.19+
Thanks!
Lukas
> ---
> drivers/pci/hotplug/pciehp_ctrl.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/pci/hotplug/pciehp_ctrl.c b/drivers/pci/hotplug/pciehp_ctrl.c
> index 529c34808440..32baba1b7f13 100644
> --- a/drivers/pci/hotplug/pciehp_ctrl.c
> +++ b/drivers/pci/hotplug/pciehp_ctrl.c
> @@ -256,6 +256,14 @@ void pciehp_handle_presence_or_link_change(struct controller *ctrl, u32 events)
> present = pciehp_card_present(ctrl);
> link_active = pciehp_check_link_active(ctrl);
> if (present <= 0 && link_active <= 0) {
> + if (ctrl->state == BLINKINGON_STATE) {
> + ctrl->state = OFF_STATE;
> + cancel_delayed_work(&ctrl->button_work);
> + pciehp_set_indicators(ctrl, PCI_EXP_SLTCTL_PWR_IND_OFF,
> + INDICATOR_NOOP);
> + ctrl_info(ctrl, "Slot(%s): Card not present\n",
> + slot_name(ctrl));
> + }
> mutex_unlock(&ctrl->state_lock);
> return;
> }
> --
> 2.25.1
