On 11.05.2023 22:10, Lukas Wunner wrote: > On Thu, May 11, 2023 at 11:00:02PM +0300, Ilpo Järvinen wrote: >> On Thu, 11 May 2023, Heiner Kallweit wrote: >>> On 11.05.2023 15:14, Ilpo Järvinen wrote: >>>> Don't assume that only the driver would be accessing LNKCTL. ASPM >>>> policy changes can trigger write to LNKCTL outside of driver's control. >>>> >>>> Use pcie_lnkctl_clear_and_set() which does proper locking to avoid >>>> losing concurrent updates to the register value. >>>> >>> >>> Wouldn't it be more appropriate to add proper locking to the >>> underlying pcie_capability_clear_and_set_word()? >> >> As per discussion for the other patch, that's where this series is now >> aiming to in v2. > > That discussion wasn't cc'ed to Heiner. For reference, this is the > message Ilpo is referring to: > > https://lore.kernel.org/linux-pci/ZF1AjOKDVlbNFJPK@bhelgaas/ Thanks for the link!
