On Tue, May 09, 2023 at 05:39:12PM +0200, Vincenzo Palazzo wrote: > --- a/drivers/pci/controller/pcie-rockchip-host.c > +++ b/drivers/pci/controller/pcie-rockchip-host.c > @@ -38,6 +38,10 @@ > #include "../pci.h" > #include "pcie-rockchip.h" > > +/* bus_scan_delay - module parameter to override the > + * device tree value, which is 0 by default. */ > +static int bus_scan_delay = -1; Please do not add new module parameters, this is not the 1990's anymore. We have per-device settings everywhere, this makes that impossible. Just use a DT value, if it is wrong, then fix the DT value! No need to have the kernel override it, that's not what DT files are for. thanks, greg k-h
