Re: [PATCH 0/3] Enclosure sysfs refactor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mariusz Tkaczyk wrote:
> On Thu, 17 Nov 2022 17:34:04 +0100
> Mariusz Tkaczyk <mariusz.tkaczyk@xxxxxxxxxxxxxxx> wrote:
> 
> > Hi Bjorn,
> > I agreed with Stuart to take over the NPEM implementation[1].
> > First part I want to share is a small refactor around enclosure interface.
> > 
> > The one sysfs change introduced is changing active LED to write-only.
> > get_active() callback is not implemented for SES which is the
> > only one enclosure API consumer now.
> > 
> > [1]
> > https://lore.kernel.org/linux-pci/cover.1643822289.git.stuart.w.hayes@xxxxxxxxx/
> > 
> > Mariusz Tkaczyk (3):
> >   misc: enclosure: remove get_active() callback
> >   misc: enclosure, ses: simplify some get callbacks
> >   misc: enclosure: update sysfs api
> > 
> >  drivers/misc/enclosure.c  | 96 ++++++++++++++++-----------------------
> >  drivers/scsi/ses.c        | 33 ++++++++------
> >  include/linux/enclosure.h | 14 ++----
> >  3 files changed, 61 insertions(+), 82 deletions(-)
> > 
> 
> Hi Bjorn,
> Could you please take a look? Let me know if you against this cleanup.
> I would like to get back to NPEM, I based my patches on top of it.

Hi Mariusz,

I don't expect Bjorn to handle enclosure updates. I expect the upstream
path for these patches is through the SCSI tree. Going forward you can
use get_maintainer.pl for this routing information.

$ ./scripts/get_maintainer.pl drivers/scsi/ses.c 
"James E.J. Bottomley" <jejb@xxxxxxxxxxxxx> (maintainer:SCSI SUBSYSTEM)
"Martin K. Petersen" <martin.petersen@xxxxxxxxxx> (maintainer:SCSI SUBSYSTEM)
linux-scsi@xxxxxxxxxxxxxxx (open list:SCSI SUBSYSTEM)
linux-kernel@xxxxxxxxxxxxxxx (open list)

I'll take a look and then you can resend to linux-scsi. I do like this
stat line:

3 files changed, 61 insertions(+), 82 deletions(-)

...makes it compelling to take a look.



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux