On Tue, May 02, 2023 at 06:08:13PM +0530, Ajay Agarwal wrote: > On Mon, May 01, 2023 at 12:21:14PM -0500, Bjorn Helgaas wrote: > > On Tue, Apr 11, 2023 at 04:40:32PM +0530, Ajay Agarwal wrote: > > > Currently the aspm driver sets ASPM_STATE_L1 as well as > > > ASPM_STATE_L1SS bits when the class driver disables L1. > > > > I would have said just "driver" -- do you mean something different by > > using "class driver"? The callers I see are garden-variety drivers > > for individual devices like hci_bcm4377, xillybus_pcie, e1000e, jme, > > etc. > > No, I do not mean anything different by "class driver". I just wanted > to name the caller drivers of the ASPM APIs as something other than > just "driver". Do you want me to change this to "driver" ? Yes, please, I think "driver" by itself is sufficient. IIUC, "class driver" generally refers to a generic or abstract driver that provides a common interface to a variety of different devices. This interface could be used by such a class driver or by the driver for a specific device, but the type of driver is not relevant to this patch. Bjorn
