Re: [PATCH v4 10/11] PCI: rockchip: Don't advertise MSI-X in PCIe capabilities

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 4/17/23 18:26, Rick Wertenbroek wrote:
> The RK3399 PCIe endpoint controller cannot generate MSI-X IRQs.
> This is documented in the RK3399 technical reference manual (TRM)
> section 17.5.9 "Interrupt Support".
> MSI-X capability should therefore not be advertised. Remove the
> MSI-X capability by editing the capability linked-list. The
> previous entry is the MSI capability, therefore get the next
> entry from the MSI-X capability entry and set it as next entry
> for the MSI capability. This in effect removes MSI-X from the list.
> Linked list before : MSI cap -> MSI-X cap -> PCIe Device cap -> ...
> Linked list now : MSI cap -> PCIe Device cap -> ...
> Signed-off-by: Rick Wertenbroek <rick.wertenbroek@xxxxxxxxx>
> Tested-by: Damien Le Moal <dlemoal@xxxxxxxxxx>

Looks good, but I think you need to add also:

Fixes: cf590b078391 ("PCI: rockchip: Add EP driver for Rockchip PCIe controller")
Cc: stable@xxxxxxxxxxxxxxx

Otherwise, feel free to add:

Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx>

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux