RE: [PATCH v12 02/19] PCI: Add INtx Mechanism Messages macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bjorn,

> From: Bjorn Helgaas, Sent: Saturday, April 15, 2023 4:00 AM
> Subject: Re: [PATCH v12 02/19] PCI: Add INtx Mechanism Messages macros
> 
> s/INtx/INTx/ in subject

Oops. I'll fix it on v13.

> On Fri, Apr 14, 2023 at 03:16:05PM +0900, Yoshihiro Shimoda wrote:
> > Add "Message Routing" and "INTx Mechanism Messages" macros to send
> > a message by a PCIe driver.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > ---
> >  include/linux/pci.h | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >
> > diff --git a/include/linux/pci.h b/include/linux/pci.h
> > index 0b57e37d8e77..ada1047035a8 100644
> > --- a/include/linux/pci.h
> > +++ b/include/linux/pci.h
> > @@ -1050,6 +1050,24 @@ enum {
> >  #define PCI_IRQ_MSIX		(1 << 2) /* Allow MSI-X interrupts */
> >  #define PCI_IRQ_AFFINITY	(1 << 3) /* Auto-assign affinity */
> >
> > +/* Message Routing */
> > +#define PCI_MSG_ROUTING_RC	0
> > +#define PCI_MSG_ROUTING_ADDR	1
> > +#define PCI_MSG_ROUTING_ID	2
> > +#define PCI_MSG_ROUTING_BC	3
> > +#define PCI_MSG_ROUTING_LOCAL	4
> > +#define PCI_MSG_ROUTING_GATHER	5
> > +
> > +/* INTx Mechanism Messages */
> > +#define PCI_CODE_ASSERT_INTA	0x20
> > +#define PCI_CODE_ASSERT_INTB	0x21
> > +#define PCI_CODE_ASSERT_INTC	0x22
> > +#define PCI_CODE_ASSERT_INTD	0x23
> > +#define PCI_CODE_DEASSERT_INTA	0x24
> > +#define PCI_CODE_DEASSERT_INTB	0x25
> > +#define PCI_CODE_DEASSERT_INTC	0x26
> > +#define PCI_CODE_DEASSERT_INTD	0x27
> 
> These look like things that should not be needed outside drivers/pci.
> If that's the case, they should go in drivers/pci/pci.h, not
> include/linux/pci.h.

I got it. I'll modify it on v13.

Best regards,
Yoshihiro Shimoda

> >  /* These external functions are only available when PCI support is enabled */
> >  #ifdef CONFIG_PCI
> >
> > --
> > 2.25.1
> >




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux