On 4/15/23 00:58, Bjorn Helgaas wrote:
[...]
>> +static void pci_ep_cfs_add_type_group(struct pci_epf_group *epf_group)
>> +{
>> + struct config_group *group;
>> +
>> + group = pci_epf_type_add_cfs(epf_group->epf, &epf_group->group);
>> + if (!group)
>> + return;
>> +
>> + if (IS_ERR(group)) {
>> + pr_err("failed to create epf type specific attributes\n");
>
> Is it possible to connect this with a device via pci_err() or
> dev_err()?
>
>> + return;
>> + }
>> +
>> + configfs_register_group(&epf_group->group, group);
>> +}
>> +
>> static void pci_epf_cfs_work(struct work_struct *work)
>> {
>> struct pci_epf_group *epf_group;
>> @@ -547,6 +542,8 @@ static void pci_epf_cfs_work(struct work_struct *work)
>> pr_err("failed to create 'secondary' EPC interface\n");
>
> Same.
I did not touch this line. It was there already. Another patch should change
this. I can add another patch if you want...
>
>> return;
>> }
>> +
>> + pci_ep_cfs_add_type_group(epf_group);
>> }
>>
>> static struct config_group *pci_epf_make(struct config_group *group,
>> --
>> 2.39.2
>>
