On Thu, Mar 30, 2023 at 05:53:48PM +0900, Damien Le Moal wrote: > For the commands COMMAND_RAISE_LEGACY_IRQ, COMMAND_RAISE_MSI_IRQ and > COMMAND_RAISE_MSIX_IRQ, the function pci_epf_test_cmd_handler() > sets the STATUS_IRQ_RAISED status flag and calls the epc function > pci_epc_raise_irq() directly. However, this is also exactly what the > pci_epf_test_raise_irq() function does. Avoid duplicating these > operations by directly using pci_epf_test_raise_irq() for the IRQ test > commands. It is OK to do so as the host side endpoint test driver always > set the correct irq type for the IRQ test commands. > > At the same time, the irq number check done for the > COMMAND_RAISE_MSI_IRQ and COMMAND_RAISE_MSIX_IRQ commands can also be > moved to pci_epf_test_raise_irq() to also check the IRQ number requested > by the host for other test commands. > > Overall, this significantly simplifies the pci_epf_test_cmd_handler() > function. s/irq/IRQ/ several times above to be consistent.
