Re: [PATCH] PCI/hotplug: Replaced down_write_nested with hotplug_slot_rwsem if ctrl->depth > 0 when taking the ctrl->reset_lock.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks Lukas.

The patch has been tested with current kernel 6.3.0-rc5 on the same setup.
The deadlock between reset_lock and device_lock has been fixed.

See details in the dmesg log: dmesg_6.3.0-rc5_fix.txt in bugzilla:

https://bugzilla.kernel.org/show_bug.cgi?id=215590

Thanks,
Anatoli

On 2023-02-19 15:21, Lukas Wunner wrote:
On Fri, Feb 17, 2023 at 06:37:54PM +0000, Deucher, Alexander wrote:
From: Bjorn Helgaas <helgaas@xxxxxxxxxx>
On Mon, Feb 13, 2023 at 09:59:52AM -0500, Anatoli Antonovitch wrote:
On 2023-01-23 14:30, Anatoli Antonovitch wrote:
I do not see a deadlock, when applying the following old patch:
https://lore.kernel.org/linux-pci/908047f7699d9de9ec2efd6b79aa752d73dab4b6.1595329748.git.lukas@xxxxxxxxx/
Can we revisit the patches again to get a fix?
The issue still reproduce and visible in the kernel 6.2.0-rc8.
This old patch would need to be updated and reposted.  There was a 0-day
bot issue and a question to be resolved.  Maybe this is all already resolved,
but it needs to be posted and tested with a current kernel.
Lukas, can you resend that patch?  We can test it.
I'm working on a patch which aims to solve these deadlocks differently,
by reducing the critical sections for which the reset_lock is held.
Please stand by.

Thanks,

Lukas



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux