On 3/31/23 14:22, Manivannan Sadhasivam wrote: > On Thu, Mar 30, 2023 at 05:53:41PM +0900, Damien Le Moal wrote: >> A PCI endpoint function driver can define function specific attributes >> under its function configfs directory using the add_cfs() endpoint >> driver operation. This is done by tighing up the mkdir operation for >> the function configfs directory to a call to the add_cfs() operation. >> However, there are no checks preventing the user from repeatedly >> creating function specific attribute directories with different names, >> resulting in the same endpoint specific attributes group being added >> multiple times, which also result in an invalid reference counting for >> the attribute groups. E.g., using the pci-epf-ntb function driver as an >> example, the user creates the function as follows: > > [...] > >> Fix this by modifying pci_epf_cfs_work() to execute the new function >> pci_ep_cfs_add_type_group() which itself calls pci_epf_type_add_cfs() >> to obtain the function specific attribute group and the group name >> (directory name) from the endpoint function driver. If the function >> driver defines an attribute group, pci_ep_cfs_add_type_group() then >> proceeds to register this group using configfs_register_group(), thus >> automatically exposing the function type pecific onfigfs attributes to > > Still you haven't fixed this typo. But I don't expect you to respin unless there > are other changes. Arg. Sorry about that. I hope it can be fixed when applying. -- Damien Le Moal Western Digital Research
