On Thu, 23 Mar 2023 at 08:16, Janne Grunau <j@xxxxxxxxxx> wrote: > > The Apple SoC devicetrees used to delete unused PCIe ports. Avoid to set > up disabled PCIe ports to keep the previous behaviour. MacOS initialized > also only ports with a known device. > > Use for_each_available_child_of_node instead of for_each_child_of_node > which takes the "status" property into account. > > Link: https://lore.kernel.org/asahi/20230214-apple_dts_pcie_disable_unused-v1-0-5ea0d3ddcde3@xxxxxxxxxx/ > Link: https://lore.kernel.org/asahi/1ea2107a-bb86-8c22-0bbc-82c453ab08ce@xxxxxxxxxx/ > Fixes: 1e33888fbe44 ("PCI: apple: Add initial hardware bring-up") > Reviewed-by: Marc Zyngier <maz@xxxxxxxxxx> > Signed-off-by: Janne Grunau <j@xxxxxxxxxx> Tested this on Asahi Fedora Remix kernel-edge on Mac Mini M1. Tested-by: Eric Curtin <ecurtin@xxxxxxxxxx> Is mise le meas/Regards, Eric Curtin > --- > Changes in v3: > - dropped Cc: stable > - rewritten commit message since the warning is fixed by 6fffbc7ae137 ("PCI: Honor firmware's > device disabled status") > - Link to v2: https://lore.kernel.org/r/20230307-apple_pcie_disabled_ports-v2-1-c3bd1fd278a4@xxxxxxxxxx > > Changes in v2: > - rewritten commit message with more details and corrections > - collected Marc's "Reviewed-by:" > - Link to v1: https://lore.kernel.org/r/20230307-apple_pcie_disabled_ports-v1-1-b32ef91faf19@xxxxxxxxxx > --- > drivers/pci/controller/pcie-apple.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c > index 66f37e403a09..f8670a032f7a 100644 > --- a/drivers/pci/controller/pcie-apple.c > +++ b/drivers/pci/controller/pcie-apple.c > @@ -783,7 +783,7 @@ static int apple_pcie_init(struct pci_config_window *cfg) > cfg->priv = pcie; > INIT_LIST_HEAD(&pcie->ports); > > - for_each_child_of_node(dev->of_node, of_port) { > + for_each_available_child_of_node(dev->of_node, of_port) { > ret = apple_pcie_setup_port(pcie, of_port); > if (ret) { > dev_err(pcie->dev, "Port %pOF setup fail: %d\n", of_port, ret); > > --- > base-commit: c9c3395d5e3dcc6daee66c6908354d47bf98cb0c > change-id: 20230307-apple_pcie_disabled_ports-0c17fb7a4738 > > Best regards, > -- > Janne Grunau <j@xxxxxxxxxx> > >
