Re: [PATCH] PCIE: pcie_set_readrq must not be allowed by PCIE EP driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/24/2012 11:08 AM, Pedanekar, Hemant wrote:
Hi,

Pratyush Anand wrote on Friday, February 24, 2012 9:28 AM:

On 2/23/2012 11:12 PM, Tejun Heo wrote:
Hello,

On Thu, Feb 23, 2012 at 03:31:29PM +0530, Pratyush Anand wrote:
Its a long pending patch.
Any decision on this patch.

Hmmm.... I really don't know what to do.  IIRC it was something lifted
from the proprietary sil driver and they probably added that to work
around performance oddities under certain configurations and I'm a bit
worried about changing it after all this time.  Is there any way to
make this conditional somehow?

I see that there is a patch in the latest kernel.

commit a1c473aa11e61bc871be16279c9bf976acf22504
Author: Benjamin Herrenschmidt<benh@xxxxxxxxxxxxxxxxxxx>
Date:   Fri Oct 14 14:56:15 2011 -0500

      pci: Clamp pcie_set_readrq() when using "performance" settings

I think, this will resolve the issue.
We are moving to the new kernel. Will check it there.

I see that the patch above considers MPS to clamp RRQ size, while I think
both should be independent, or perhaps I am missing something.


Please also see following patch for completeness.

commit b03e7495a862b028294f59fc87286d6d78ee7fa1
Author: Jon Mason <mason@xxxxxxxx>
Date:   Wed Jul 20 15:20:54 2011 -0500

    PCI: Set PCI-E Max Payload Size on fabric

Regards
Pratyush
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux