On Tue, 14 Mar 2023, Niklas Schnelle wrote: > those drivers requiring them. For the DEFXX driver there use of I/O > ports is optional and we only need to fence those paths.can It also Some writing mess-up here, should it read: "For the DEFXX driver the use of I/O ports is optional and we only need to fence those paths. It also [...]" ? > diff --git a/drivers/net/fddi/Kconfig b/drivers/net/fddi/Kconfig > index 846bf41c2717..fa3f1e0fe143 100644 > --- a/drivers/net/fddi/Kconfig > +++ b/drivers/net/fddi/Kconfig > @@ -29,7 +29,7 @@ config DEFZA > > config DEFXX > tristate "Digital DEFTA/DEFEA/DEFPA adapter support" > - depends on FDDI && (PCI || EISA || TC) > + depends on FDDI && (PCI || EISA || TC) && HAS_IOPORT This part would incorrectly disable the driver for !HAS_IOPORT and is not needed given the change below: > diff --git a/drivers/net/fddi/defxx.c b/drivers/net/fddi/defxx.c > index 1fef8a9b1a0f..5f386eba9618 100644 > --- a/drivers/net/fddi/defxx.c > +++ b/drivers/net/fddi/defxx.c > @@ -254,7 +254,7 @@ static const char version[] = > #define DFX_BUS_TC(dev) 0 > #endif > > -#if defined(CONFIG_EISA) || defined(CONFIG_PCI) > +#ifdef HAS_IOPORT > #define dfx_use_mmio bp->mmio > #else > #define dfx_use_mmio true is it? Maciej
