Hi Niklas, On Tue, Mar 14, 2023 at 1:12 PM Niklas Schnelle <schnelle@xxxxxxxxxxxxx> wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add HAS_IOPORT as dependency for > those drivers using them. > > Co-developed-by: Arnd Bergmann <arnd@xxxxxxxxxx> > Signed-off-by: Niklas Schnelle <schnelle@xxxxxxxxxxxxx> Thanks for your patch! > --- a/drivers/ata/Kconfig > +++ b/drivers/ata/Kconfig > @@ -342,6 +342,7 @@ endif # HAS_DMA > > config ATA_SFF > bool "ATA SFF support (for legacy IDE and PATA)" > + depends on HAS_IOPORT > default y > help > This option adds support for ATA controllers with SFF ATA_SFF is a dependency for lots of (S)ATA drivers. (at least) The following don't use I/O port access: CONFIG_SATA_RCAR (arm/arm64) CONFIG_PATA_FALCON (m68k/atari and m68k/q40) CONFIG_PATA_GAYLE (m68k/amiga) CONFIG_PATA_BUDDHA (m68k/amiga) (at least) The following can use either MMIO or I/O port accesses: CONFIG_PATA_PLATFORM (m68k/mac) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds