On Sun, 13 Nov 2022 23:23:26 -0800, Josh Triplett wrote: > pcie-kirin uses regmaps, and needs to pull them in; otherwise, with > CONFIG_PCIE_KIRIN=y and without CONFIG_REGMAP: > > drivers/pci/controller/dwc/pcie-kirin.c:359:21: error: variable ‘pcie_kirin_regmap_conf’ has initializer but incomplete type > 359 | static const struct regmap_config pcie_kirin_regmap_conf = { > > Similarly, without CONFIG_REGMAP_MMIO, pcie-kirin produces a linker > failure looking for __devm_regmap_init_mmio_clk. > > [...] Applied to controller/kirin, thanks! [1/1] PCI: kirin: select REGMAP and REGMAP_MMIO https://git.kernel.org/pci/pci/c/3a2776e8a0e1 Thanks, Lorenzo