On 3/6/23 10:10 AM, Niklas Schnelle wrote: > Prior to commit 960ac3626487 ("s390/pci: allow zPCI zbus without > a function zero") enabling and scanning a PCI function had to > potentially be postponed until the function with devfn zero on that bus > was plugged. While the commit removed the waiting itself extra code to > scan all functions on the PCI bus once function zero appeared was > missed. Remove that code and the outdated comments about waiting for > function zero. > > Signed-off-by: Niklas Schnelle <schnelle@xxxxxxxxxxxxx> > --- > arch/s390/pci/pci.c | 23 +++-------------------- > 1 file changed, 3 insertions(+), 20 deletions(-) > > diff --git a/arch/s390/pci/pci.c b/arch/s390/pci/pci.c > index e16afacc8fd1..f5709b5dae7a 100644 > --- a/arch/s390/pci/pci.c > +++ b/arch/s390/pci/pci.c > @@ -874,32 +874,15 @@ bool zpci_is_device_configured(struct zpci_dev *zdev) > * @fh: The general function handle supplied by the platform > * > * Given a device in the configuration state Configured, enables, scans and > - * adds it to the common code PCI subsystem if possible. If the PCI device is > - * parked because we can not yet create a PCI bus because we have not seen > - * function 0, it is ignored but will be scanned once function 0 appears. > - * If any failure occurs, the zpci_dev is left disabled. > + * adds it to the common code PCI subsystem if possible.If any failure occurs, Nit: missing space after period here Also, while you're at this, commit 960ac3626487 removed the function 0 check from zpci_bus_scan_bus but the comment block for zpci_bus_scan_bus is still outdated. Please fix also with this patch. With that: Reviewed-by: Matthew Rosato <mjrosato@xxxxxxxxxxxxx>