Hi Lars On Thu, Mar 02, 2023 at 09:26:51AM -0800, Lars-Peter Clausen wrote: > On 2/20/23 19:46, Cai Huoqing wrote: > > +void dw_hdma_v0_core_register(struct dw_edma *dw) > > +{ > > + dw->core = &dw_hdma_v0_core; > > +} > > Where is dw_hdma_v0_core_register() called? Indeed. Good catch! The respective change has been missing since v2: @@ -952,7 +953,10 @@ int dw_edma_probe(struct dw_edma_chip *chip) dw->chip = chip; - dw_edma_v0_core_register(dw); + if (dw->chip->mf == EDMA_MF_HDMA_NATIVE) + dw_hdma_v0_core_register(dw); + else + dw_edma_v0_core_register(dw); @Cai, please fix that. -Serge(y) > >