On 24/02/2023 20:57, Sajid Dalvi wrote: > When the Root Complex is probed, the default behavior is to spin in a loop > waiting for the link to come up. In some systems the link is not brought up > during probe, but later in the context of an end-point turning on. > This property will allow the loop to be skipped. > > Signed-off-by: Sajid Dalvi <sdalvi@xxxxxxxxxx> > --- Thank you for your patch. There is something to discuss/improve. > Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml > index 1a83f0f65f19..0b8950a73b7e 100644 > --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml > @@ -197,6 +197,14 @@ properties: > - contains: > const: msi > > + snps,skip-wait-link-up: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + When the Root Complex is probed, the default behavior is to spin in a > + loop waiting for the link to come up. In some systems the link is not > + brought up during probe, but later in the context of an end-point turning > + on. This property will allow the loop to be skipped. I fail to see how probe behavior is related to properties of hardware. You describe OS behavior, not hardware. This does not look like belonging to DT. Best regards, Krzysztof
