Re: [PATCH RESEND] PCI: endpoint: functions/pci-epf-test: Fix dma_chan direction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 22, 2023 at 12:49:14AM +0000, Yoshihiro Shimoda wrote:
> > From: Bjorn Helgaas, Sent: Wednesday, February 22, 2023 5:08 AM
> > On Tue, Feb 21, 2023 at 07:17:06PM +0900, Yoshihiro Shimoda wrote:
> > > In the pci_epf_test_init_dma_chan(), epf_test->dma_chan_rx
> > > is assigned from dma_request_channel() with DMA_DEV_TO_MEM as
> > > filter.dma_mask. However, in the pci_epf_test_data_transfer(),
> > > if the dir is DMA_DEV_TO_MEM, it should use epf->dma_chan_rx,
> > > but it used epf_test->dma_chan_tx. So, fix it. Otherwise,
> > > results of pcitest with enabled DMA will be NG on eDMA
> > > environment.
> > 
> > "NG"?
> 
> I'm sorry, I completely mistook this.
> This should be "NOT OKAY", not "NG".

That should match something printed by pcitest, which would be a good
thing.  Thanks for expanding it for non-pcitest experts like me!

Bjorn



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux