RE: [EXT] [PATCH] PCI: endpoint: functions/pci-epf-test: Fix dma_chan direction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Frank,

> From: Frank Li, Sent: Wednesday, February 22, 2023 1:06 AM
> 
> >
> > diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c
> > b/drivers/pci/endpoint/functions/pci-epf-test.c
> > index 55283d2379a6..3a720ed4655e 100644
> > --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> > +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> > @@ -113,7 +113,7 @@ static int pci_epf_test_data_transfer(struct
> > pci_epf_test *epf_test,
> >                                       enum dma_transfer_direction dir)
> >  {
> >         struct dma_chan *chan = (dir == DMA_DEV_TO_MEM) ?
> 
> Can you use (dir == DMA_MEM_TO_DEV)? match following check
> dma_addr_t dma_local = (dir == DMA_MEM_TO_DEV) ?

Yes, I'll use (dir == DMA_MEM_TO_DEV) instead.

Best regards,
Yoshihiro Shimoda

> Frank Li
> 
> > -                                epf_test->dma_chan_tx : epf_test->dma_chan_rx;
> > +                                epf_test->dma_chan_rx : epf_test->dma_chan_tx;
> >         dma_addr_t dma_local = (dir == DMA_MEM_TO_DEV) ? dma_src :
> > dma_dst;
> >         enum dma_ctrl_flags flags = DMA_CTRL_ACK | DMA_PREP_INTERRUPT;
> >         struct pci_epf *epf = epf_test->epf;
> > --
> > 2.25.1





[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux