On 2/16/23 19:15, Manivannan Sadhasivam wrote: > On Wed, Feb 15, 2023 at 12:21:45PM +0900, Damien Le Moal wrote: >> pci_epf_type_add_cfs() is called only from pci_ep_cfs_add_type_group() >> in drivers/pci/endpoint/pci-ep-cfs.c, so there is no need to export it >> and function drivers should not call this function directly. >> > > Where is the pci_ep_cfs_add_type_group() function defined? In patch 1. >> /** >> * pci_epf_unbind() - Notify the function driver that the binding between the >> diff --git a/drivers/pci/endpoint/pci-epf.h b/drivers/pci/endpoint/pci-epf.h >> new file mode 100644 >> index 000000000000..b2f351afd623 >> --- /dev/null >> +++ b/drivers/pci/endpoint/pci-epf.h > > When there is already a pci-epf.h header available, creating one more even > under different location will create ambiguity. Please rename it as internal.h > or something relevant. OK. -- Damien Le Moal Western Digital Research
