On 16/02/2023 11:55, Krzysztof Kozlowski wrote: > On 14/02/2023 13:13, Shradha Todi wrote: >> The current PCIe controller driver is being used for Exynos5433 >> SoC only. In order to extend this driver for all SoCs manufactured >> by Samsung using DWC PCIe controller, rename this driver and make >> it Samsung specific instead of any Samsung SoC name. >> >> Signed-off-by: Shradha Todi <shradha.t@xxxxxxxxxxx> >> --- >> MAINTAINERS | 4 +- >> drivers/pci/controller/dwc/Kconfig | 6 +- >> drivers/pci/controller/dwc/Makefile | 2 +- >> drivers/pci/controller/dwc/pci-samsung.c | 443 +++++++++++++++++++++++ > > Rename missing. I am anyway not sure if this is good. What's wrong with > old name? OK, looking a bit at your further patches - doesn't it make sense to split a bit the driver? Maybe keep the core as pci-samsung, but some other parts in pci-exynso5433? Best regards, Krzysztof