On Wed, Feb 15, 2023 at 12:21:50PM +0900, Damien Le Moal wrote: > Make the pci-epf-test driver more verbose with dynamic debug messages > using dev_dbg(). Also add some dev_err() error messages to help > troubleshoot issues. > > Signed-off-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx> > --- > drivers/pci/endpoint/functions/pci-epf-test.c | 69 +++++++++++++++---- > 1 file changed, 56 insertions(+), 13 deletions(-) > > diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c > index f630393e8208..9b791f4a7ffb 100644 > --- a/drivers/pci/endpoint/functions/pci-epf-test.c > +++ b/drivers/pci/endpoint/functions/pci-epf-test.c > @@ -330,6 +330,10 @@ static int pci_epf_test_copy(struct pci_epf_test *epf_test, bool use_dma) > enum pci_barno test_reg_bar = epf_test->test_reg_bar; > volatile struct pci_epf_test_reg *reg = epf_test->reg[test_reg_bar]; note, volatile is almost always wrong, please fix that up. thanks, greg k-h
