On 2/14/23 8:48 AM, Dave Jiang wrote:
> With commit [1] upstream that enables AER reporting by default for all PCIe
> devices, the documentation for pcie_enable_pcie_error_reporting() is no
/s/pcie_enable_pcie_error_reporting/pci_enable_pcie_error_reporting
> longer necessary. Remove references to the helper function.
Before removing the documentation, are the references removed from the
code? I think Bjorn only cleaned up the net drivers.
>
> [1]: commit f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native")
>
> Suggested-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> Signed-off-by: Dave Jiang <dave.jiang@xxxxxxxxx>
> ---
> Documentation/PCI/pcieaer-howto.rst | 18 ------------------
> 1 file changed, 18 deletions(-)
>
> diff --git a/Documentation/PCI/pcieaer-howto.rst b/Documentation/PCI/pcieaer-howto.rst
> index 0b36b9ebfa4b..a82802795a06 100644
> --- a/Documentation/PCI/pcieaer-howto.rst
> +++ b/Documentation/PCI/pcieaer-howto.rst
> @@ -135,15 +135,6 @@ hierarchy and links. These errors do not include any device specific
> errors because device specific errors will still get sent directly to
> the device driver.
>
> -Configure the AER capability structure
> ---------------------------------------
> -
> -AER aware drivers of PCI Express component need change the device
> -control registers to enable AER. They also could change AER registers,
> -including mask and severity registers. Helper function
> -pci_enable_pcie_error_reporting could be used to enable AER. See
> -section 3.3.
> -
> Provide callbacks
> -----------------
>
> @@ -214,15 +205,6 @@ to mmio_enabled.
>
> helper functions
> ----------------
> -::
> -
> - int pci_enable_pcie_error_reporting(struct pci_dev *dev);
> -
> -pci_enable_pcie_error_reporting enables the device to send error
> -messages to root port when an error is detected. Note that devices
> -don't enable the error reporting by default, so device drivers need
> -call this function to enable it.
> -
> ::
>
> int pci_disable_pcie_error_reporting(struct pci_dev *dev);
>
>
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
