Re: [External] : Re: [PATCH] PCI: Fix build error when CONFIG_PCI_MSI disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



if, new function going to part of #else case . that is absolutely fine.

but that is not present in given PATCH.

Thanks,

Alok

On 2/11/2023 2:42 AM, Reinette Chatre wrote:
Hi Alok,

On 2/10/2023 12:45 PM, ALOK TIWARI wrote:
shall we need to define this function under -> #ifndef CONFIG_PCI_MSI

#ifndef CONFIG_PCI_MSI

+static inline struct msi_map
+pci_msix_alloc_irq_at(struct pci_dev *dev, unsigned int index,
+              const struct irq_affinity_desc *affdesc)
+{
+    struct msi_map map = { .index = -ENOSYS };
+
+    return map;
+}
+
+static inline void pci_msix_free_irq(struct pci_dev *pdev, struct msi_map map)
+{
+}
+#endif
No need. include/linux/pci.h already has those definitions.

include/linux/pci.h already has:

#ifdef CONFIG_PCI_MSI

...

#else

...
/*  new function definitions will be inserted here */
...

#endif


Reinette



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux