Hi Bjorn, Sorry for the belated response. On Wed, Jan 18, 2023 at 7:14 AM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > > On Mon, Dec 26, 2022 at 11:30:31PM +0800, Kai-Heng Feng wrote: > > We are seeing igc ethernet device on Thunderbolt dock stops working > > after S3 resume because of AER error, or even make S3 resume freeze: > > pcieport 0000:00:1d.0: AER: Multiple Corrected error received: 0000:00:1d.0 > > pcieport 0000:00:1d.0: PCIe Bus Error: severity=Corrected, type=Transaction Layer, (Receiver ID) > > pcieport 0000:00:1d.0: device [8086:7ab0] error status/mask=00008000/00002000 > > pcieport 0000:00:1d.0: [15] HeaderOF > > pcieport 0000:00:1d.0: AER: Multiple Uncorrected (Non-Fatal) error received: 0000:00:1d.0 > > pcieport 0000:00:1d.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID) > > pcieport 0000:00:1d.0: device [8086:7ab0] error status/mask=00100000/00004000 > > pcieport 0000:00:1d.0: [20] UnsupReq (First) > > pcieport 0000:00:1d.0: AER: TLP Header: 34000000 0a000052 00000000 00000000 > > pcieport 0000:00:1d.0: AER: Error of this Agent is reported first > > pcieport 0000:04:01.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID) > > pcieport 0000:04:01.0: device [8086:1136] error status/mask=00300000/00000000 > > pcieport 0000:04:01.0: [20] UnsupReq (First) > > pcieport 0000:04:01.0: [21] ACSViol > > pcieport 0000:04:01.0: AER: TLP Header: 34000000 04000052 00000000 00000000 > > thunderbolt 0000:05:00.0: AER: can't recover (no error_detected callback) > > Is this a regression? E.g., is this something that started after > f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native") or > something similar? Reverting the commit doesn't help. Because 0000:00:1d.0 is already native so AER is already enabled. Kai-Heng > > Bjorn