On Fri, Feb 03, 2023 at 05:06:21PM +0800, Li, Ming wrote: > On 1/24/2023 8:15 PM, Jonathan Cameron wrote: > > On Mon, 23 Jan 2023 11:16:00 +0100 Lukas Wunner <lukas@xxxxxxxxx> wrote: > > > +/** > > > + * pci_doe_destroy_mb() - Destroy a DOE mailbox object > > > + * > > > + * @ptr: Pointer to DOE mailbox > > > + * > > > + * Destroy all internal data structures created for the DOE mailbox. > > > + */ > > > +static void pci_doe_destroy_mb(void *ptr) > > I don't get why uses "void *ptr" as the parameter of this function, > maybe I miss something. I guess we can use "struct pci_doe_mb *doe_mb" > as the parameter. It's a "void *ptr" argument so that pci_doe_destroy_mb() can serve as a callback for devm_add_action(). But as you've correctly noted, devm_add_action() is removed in a subsequent commit and then the argument is adjusted to "struct pci_doe_mb *doe_mb". Thanks, Lukas
