在 2023/1/18 03:46, Bjorn Helgaas 写道: > On Tue, Jan 17, 2023 at 05:27:46PM +0800, Edward Chow wrote: >> Loading calibration data from an OF device tree node not declared >> compatible with the device (e.g. a PCI device with calibration data >> from corresponding DT node gets replaced, so the newly installed >> device become incompatible with the node) or driver may lead to fatal >> result, e.g. kernel panic. > Please include a link to a bug report and include a few lines of the > oops or panic directly in the commit log so when users see this > problem, they can search for the text and possibly find this fix. > >> The driver should check whether the DT node corresponding to the >> device compatible with it, and load calibration data only from >> compatible node. > If you read this commit log carefully, it doesn't actually say what > this patch *does*. It has some background and this assertion about > what drivers *should* do, but it doesn't say what this patch does. > > Suggest structure like this (flesh out with the relevant DT property > names, etc): > > For PCI ath9k devices, load calibration data only if there is a DT > node corresponding to the device with XXX ... > > More details: https://chris.beams.io/posts/git-commit/ > Thanks for pointing it out. The commit log of the last two patch has been reworded with required content, and sent to the current thread earlier.
