On 1/17/23 12:59, Bjorn Helgaas wrote:
On Tue, Dec 27, 2022 at 10:45:26AM +0530, Aman Gupta/FDS SW /SSIR/Engineer/Samsung Electronics wrote:
...
Thanks for review and suggestion. I understand that we would like to
reuse and preserve the history of tools/pci/pcietest.c. So we have
two approaches:
1: Using git mv command move existing code from tools/pci/ to
tools/testing/selftest/drivers/pci/ and then update the file to
convert to kselftest framework. I thought about this but after
movement, when we move it to kselftest format it is going to be huge
churn and we will be having modification in almost all lines.
2: Develop kselftest based driver in
tools/testing/selftest/drivers/pci/ and eventually delete existing
file from tools/pci/ folder providing justification in commit
message.
From my viewpoint, going with the second approach makes more sense
because if almost complete file is getting modified, and it will
make the review process complex and anyways there is not much code
reusability.
Please let me know if you have any other thought
process or if I am missing anything to understand your approach.
I vote for the first approach, with "git mv" and subsequent conversion
(in separate patches, of course). If git knows about the move,
"git log --follow" will be useful even though the conversion will be a
big patch. Adding a new test with the connection to the old one only
in the commit log makes more work for people who dig through the
history in the future.
Thanks Bjorn for explaining this in more detail that I did.
Please send revised patches following the first approach.
thanks,
-- Shuah
