On 26/01/2023 14:50, Rick Wertenbroek wrote: > Added generation of legacy IRQ (INTx) for the RK3399 SoC PCIe EP core. Here and in all other patches and subjects: Use imperative, not past tense. https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 "Fix legacy IRQ", not "Fixed legacy IRQ". > The generation of the legacy interrupt was validated with the PCIe EP > test driver. Generation of IRQ through the core is documented in the > TRM and is done through the PCIE_CLIENT_LEGACY_INT_CTRL register of > the core. > If this is a fix, you need fixes tag and maybe cc-stable. Also the bug should be described - it's effect, impact. Then the patch should be first in the series (or even entirely separate). Best regards, Krzysztof
