On Tue, Jan 24, 2023 at 10:32:08AM +0000, Jonathan Cameron wrote: > On Mon, 23 Jan 2023 16:33:36 -0800 Ira Weiny <ira.weiny@xxxxxxxxx> wrote: > > Lukas Wunner wrote: > > > Gregory Price reports a WARN splat with CONFIG_DEBUG_OBJECTS=y upon CXL > > > probing because pci_doe_submit_task() invokes INIT_WORK() instead of > > > INIT_WORK_ONSTACK() for a work_struct that was allocated on the stack. > > > > > > All callers of pci_doe_submit_task() allocate the work_struct on the > > > stack, so replace INIT_WORK() with INIT_WORK_ONSTACK() as a backportable > > > short-term fix. [...] > It's an unusual requirement, but this is indeed the minimal fix > given current users. Obviously becomes more sensible later in the > series once you make the API synchronous only. Okay, I'll amend the commit message as follows when respinning to make more obvious what's being done here: The long-term fix implemented by a subsequent commit is to move to a synchronous API which allocates the work_struct internally in the DOE library. Thanks, Lukas