On Mon, 23 Jan 2023 16:35:54 -0800
Ira Weiny <ira.weiny@xxxxxxxxx> wrote:
> Lukas Wunner wrote:
> > After a pci_doe_task completes, its work_struct needs to be destroyed
> > to avoid a memory leak with CONFIG_DEBUG_OBJECTS=y.
> >
> > Fixes: 9d24322e887b ("PCI/DOE: Add DOE mailbox support functions")
> > Tested-by: Ira Weiny <ira.weiny@xxxxxxxxx>
>
> Reviewed-by: Ira Weiny <ira.weiny@xxxxxxxxx>
Good find.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
>
> > Signed-off-by: Lukas Wunner <lukas@xxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx # v6.0+
> > Cc: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> > ---
> > drivers/pci/doe.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/pci/doe.c b/drivers/pci/doe.c
> > index 12a6752351bf..7451b5732044 100644
> > --- a/drivers/pci/doe.c
> > +++ b/drivers/pci/doe.c
> > @@ -224,6 +224,7 @@ static void signal_task_complete(struct pci_doe_task *task, int rv)
> > {
> > task->rv = rv;
> > task->complete(task);
> > + destroy_work_on_stack(&task->work);
> > }
> >
> > static void signal_task_abort(struct pci_doe_task *task, int rv)
> > --
> > 2.39.1
> >
>
>
