On Sat, 21 Jan 2023 17:04:20 +0000, Lizhe <sensor1010@xxxxxxx> wrote: > > use devm_ioremap replace ioremap > > Signed-off-by: Lizhe <sensor1010@xxxxxxx> > --- > drivers/pci/msi/msi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/msi/msi.c b/drivers/pci/msi/msi.c > index 1f716624ca56..184eca85b88b 100644 > --- a/drivers/pci/msi/msi.c > +++ b/drivers/pci/msi/msi.c > @@ -566,7 +566,7 @@ static void __iomem *msix_map_region(struct pci_dev *dev, > table_offset &= PCI_MSIX_TABLE_OFFSET; > phys_addr = pci_resource_start(dev, bir) + table_offset; > > - return ioremap(phys_addr, nr_entries * PCI_MSIX_ENTRY_SIZE); > + return devm_ioremap(&dev->dev, phys_addr, nr_entries * PCI_MSIX_ENTRY_SIZE); > } And where is the unmap dealt with? From what I can see, this will probably explode when the device is removed... M. -- Without deviation from the norm, progress is not possible.
