On 1/19/2023 10:40 AM, Bjorn Helgaas wrote:
[+cc Sathy]
On Thu, Jan 19, 2023 at 10:28:16AM -0800, Tony Nguyen wrote:
On 1/18/2023 3:46 PM, Bjorn Helgaas wrote:
From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration.
Remove the redundant pci_enable_pcie_error_reporting() call from the
driver. Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.
Note that this doesn't control interrupt generation by the Root Port; that
is controlled by the AER Root Error Command register, which is managed by
the AER service driver.
Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
Cc: Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx>
Cc: Tony Nguyen <anthony.l.nguyen@xxxxxxxxx>
Cc: intel-wired-lan@xxxxxxxxxxxxxxxx
Cc: netdev@xxxxxxxxxxxxxxx
---
drivers/net/ethernet/intel/e1000e/netdev.c | 7 -------
1 file changed, 7 deletions(-)
Reviewed-by: Tony Nguyen <anthony.l.nguyen@xxxxxxxxx>
Thanks a million for taking a look at these, Tony!
These driver patches are all independent and have no dependency on the
1/9 PCI/AER patch. What's your opinion on merging these? Should they
go via netdev? Should they be squashed into a single patch that does
all the Intel drivers at once?
I'm happy to squash them and/or merge them via the PCI tree, whatever
is easiest.
Since there's no dependency, IMO, it'd make sense to go through
Intel-wired-lan/netdev. Keeping them per driver is fine.
Thanks,
Tony
