On Mon, Jan 16, 2023 at 06:32:54PM +0000, Alexey Bogoslavsky wrote: > From: Alexey Bogoslavsky <mailto:Alexey.Bogoslavsky@xxxxxxx> > > A bug was found in SN730 WD SSD that causes occasional false AER reporting > of correctable errors. While functionally harmless, this causes error > messages to appear in the system log (dmesg) which, in turn, causes > problems in automated platform validation tests. Since the issue can not > be fixed by FW, customers asked for correctable error reporting to be > quirked out in the kernel for this particular device. > > The patch was manually verified. It was checked that correctable errors > are still detected but ignored for the target device (SN730), and are both > detected and reported for devices not affected by this quirk. > > Signed-off-by: Alexey Bogoslavsky mailto:alexey.bogoslavsky@xxxxxxx > --- > drivers/pci/pcie/aer.c | 3 +++ > drivers/pci/quirks.c | 6 ++++++ > include/linux/pci.h | 1 + > include/linux/pci_ids.h | 4 ++++ > 4 files changed, 14 insertions(+) > > diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c > index d7ee79d7b192..5cc24d28b76d 100644 > --- a/drivers/pci/pcie/aer.c > +++ b/drivers/pci/pcie/aer.c > @@ -721,6 +721,9 @@ void aer_print_error(struct pci_dev *dev, struct aer_err_info *info) > goto out; > } > > + if ((info->severity == AER_CORRECTABLE) && dev->ignore_correctable_errors) No need for the inner braces. > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_WESTERN_DIGITAL, PCI_DEVICE_ID_WESTERN_DIGITAL_SN730, wd_ignore_correctable_errors); Overly long line. Also wd_ seems like an odd prefix, I'd do pci_ instead. But overall I'm not really sure it's worth adding code just to surpress a harmless warning.
