On 2023/1/12 20:38, Jason Gunthorpe wrote:
On Thu, Jan 12, 2023 at 04:46:29PM +0800, Lu Baolu wrote:
-int pci_enable_pasid(struct pci_dev *pdev, int features);
+int pci_enable_pasid(struct pci_dev *pdev, int features, bool
transled_only);
Please use a named flag so we can grep for it..
Sure. What do you think of this naming?
+ * @flags: device-specific flags
+ * - PCI_PASID_TRANSLED_REQ_ONLY: The PCI device only issues PASID
+ * memory requests of translated type.
Discuss in the commit message that this is a temporary step and that
pci_enable_pasid() needs to be moved to the drivers
I will add below in commit message:
At present, it is a common practice to enable/disable PCI PASID in the
iommu drivers. Considering that the device driver knows more about the
specific device, we will follow up by moving pci_enable_pasid() into
the specific device drivers.
--
Best regards,
baolu
