Hello, On Wed, Jan 11, 2023 at 12:53:15PM +0000, daire.mcnamara@xxxxxxxxxxxxx wrote: > From: Daire McNamara <daire.mcnamara@xxxxxxxxxxxxx> > > Enable building this driver as a module. The expected use case is the > driver is built as a module, is installed when needed, and cannot be > removed once installed. > > The remove() callback is not implemented as removing a driver with > INTx and MSI interrupt handling is inherently unsafe. Note this is a misconception. Not providing a remove callback doesn't prevent the driver from being unbound. However the driver has .suppress_bind_attrs = true, which prevents unbinding. (So the patch looks fine to me, just the commit log could be improved.) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
