Re: [PATCH net-next 0/7] Remove three Sun net drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 1/6/23 15:00, Anirudh Venkataramanan wrote:
This series removes the Sun Cassini, LDOM vswitch and sunvnet drivers.

In a recent patch series that touched these drivers [1], it was suggested
that these drivers should be removed completely. git logs suggest that
there hasn't been any significant feature addition, improvement or fixes
to user-visible bugs in a while. A web search didn't indicate any recent
discussions or any evidence that there are users out there who care about
these drivers.

The idea behind putting out this series is to either establish that these
drivers are used and should be maintained, or remove them.
Anirudh,

The Sun LDOM vswitch and sunvnet drivers are still in use, please do not remove them or the event tracing. We use them internally and you don't see any discussions because they generally work fine (AFAIK). I think you are also going to break things by removing Sun Cassini support, but I am not using it personally.
What user visible bugs are you referring to here?


Thanks
Karl

While the bulk of the code removal is in the networking s, and so
multiple subsystem lists are cc'd. Here's a quick breakdown:

   - patches 1/7 and 5/7 remove the drivers (netdev)
   - patch 2/7 removes Sun device IDs from pci_ids.h (linux-pci)
   - patch 3/7 changes ppc6xx_defconfig (linuxppc)
   - patch 4/7 changes MIPS mtx1_defconfig (linux-mips)
   - patch 6/7 removes the event tracing header sunvnet.h (linux-trace)
   - patch 7/7 changes sparc64_defconfig (sparclinux)

This series was compile tested as follows:

make O=b1 ARCH=mips CROSS_COMPILE=mips64-linux-gnu- defconfig
make -j$(nproc) O=b1 ARCH=mips CROSS_COMPILE=mips64-linux-gnu- all

make O=b2 ARCH=sparc64 CROSS_COMPILE=sparc64-linux-gnu- defconfig
make -j$(nproc) O=b2 ARCH=sparc64 CROSS_COMPILE=sparc64-linux-gnu- all

make O=b3 ARCH=powerpc CROSS_COMPILE=ppc64-linux-gnu- ppc6xx_defconfig
make -j$(nproc) O=b3 ARCH=powerpc CROSS_COMPILE=ppc64-linux-gnu- all

[1] https://lore.kernel.org/netdev/99629223-ac1b-0f82-50b8-ea307b3b0197@xxxxxxxxx/T/#t

Suggested-by: Leon Romanovsky <leon@xxxxxxxxxx>
Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@xxxxxxxxx>

Anirudh Venkataramanan (7):
   ethernet: Remove the Sun Cassini driver
   PCI: Remove PCI IDs used by the Sun Cassini driver
   powerpc: configs: Remove reference to CONFIG_CASSINI
   mips: configs: Remove reference to CONFIG_CASSINI
   ethernet: Remove the Sun LDOM vswitch and sunvnet drivers
   sunvnet: Remove event tracing file
   sparc: configs: Remove references to CONFIG_SUNVNET and CONFIG_LDMVSW

  arch/mips/configs/mtx1_defconfig          |    1 -
  arch/powerpc/configs/ppc6xx_defconfig     |    1 -
  arch/sparc/configs/sparc64_defconfig      |    2 -
  drivers/net/ethernet/sun/Kconfig          |   35 -
  drivers/net/ethernet/sun/Makefile         |    4 -
  drivers/net/ethernet/sun/cassini.c        | 5215 ---------------------
  drivers/net/ethernet/sun/cassini.h        | 2900 ------------
  drivers/net/ethernet/sun/ldmvsw.c         |  476 --
  drivers/net/ethernet/sun/sunvnet.c        |  567 ---
  drivers/net/ethernet/sun/sunvnet_common.c | 1813 -------
  drivers/net/ethernet/sun/sunvnet_common.h |  157 -
  include/linux/pci_ids.h                   |    2 -
  include/trace/events/sunvnet.h            |  140 -
  13 files changed, 11313 deletions(-)
  delete mode 100644 drivers/net/ethernet/sun/cassini.c
  delete mode 100644 drivers/net/ethernet/sun/cassini.h
  delete mode 100644 drivers/net/ethernet/sun/ldmvsw.c
  delete mode 100644 drivers/net/ethernet/sun/sunvnet.c
  delete mode 100644 drivers/net/ethernet/sun/sunvnet_common.c
  delete mode 100644 drivers/net/ethernet/sun/sunvnet_common.h
  delete mode 100644 include/trace/events/sunvnet.h


base-commit: 6bd4755c7c499dbcef46eaaeafa1a319da583b29




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux