On Thu, Dec 22, 2022 at 09:58:30AM -0700, Shuah Khan wrote: > On 10/6/22 23:39, Aman Gupta wrote: > > This patch enables the support to perform selftest on PCIe endpoint > > driver present in the system. The following tests are currently > > performed by the selftest utility > > > > 1. BAR Tests (BAR0 to BAR5) > > 2. MSI Interrupt Tests (MSI1 to MSI32) > > 3. Read Tests (For 1, 1024, 1025, 1024000, 1024001 Bytes) > > 4. Write Tests (For 1, 1024, 1025, 1024000, 1024001 Bytes) > > 5. Copy Tests (For 1, 1024, 1025, 1024000, 1024001 Bytes) > > > > Signed-off-by: Aman Gupta <aman1.gupta@xxxxxxxxxxx> > > Signed-off-by: Padmanabhan Rajanbabu <p.rajanbabu@xxxxxxxxxxx> > > Adding Bjorn Helgaas to the thread. > > Adding pcit test under selftests is good. There is another pcitest > under tools/pci. I would like to see if the existing code in > tools/pci/pcitest.c can be leveraged. > > As part of this test work, also look into removing tools/pci so > we don't have to maintain duplicate code in two places. > It has been agreed in a thread with Greg [1] to {re}move the tests under tools/pci and utilize the kselftest. Thanks, Mani [1] https://lore.kernel.org/lkml/Y2FTWLw0tKuZ9Cdl@xxxxxxxxx/ > thanks, > -- Shuah -- மணிவண்ணன் சதாசிவம்