On 2022-12-18 19:57:02 +0900, Krzysztof Wilczyński wrote:
> Thank you for sending the patch over! However, if possible,
> can you send it as plain text without any multi-part MIME
> involved?
ACK.
> If possible, it would be nice to mention that this needed
> to make sure that there is enough space to correctly
> NULL-terminate the ID string.
ACK.
So, here goes the corrected text:
Although unlikely, the 'id' value may be as big as 4294967295
(uint32_max) and "virtfn4294967295\0" would require 17 bytes
instead of 16 to make sure that buffer has enough space to
properly NULL-terminate the ID string.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: dd7cc44d0 ("PCI: add SR-IOV API for Physical Function driver")
Signed-off-by: Alexey V. Vissarionov <gremlin@xxxxxxxxxxxx>
diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
index 9522175..ad54a07 100644
--- a/drivers/pci/iov.c
+++ b/drivers/pci/iov.c
@@ -14,7 +14,7 @@
#include <linux/delay.h>
#include "pci.h"
-#define VIRTFN_ID_LEN 16
+#define VIRTFN_ID_LEN 17
int pci_iov_virtfn_bus(struct pci_dev *dev, int vf_id)
{
--
Alexey V. Vissarionov
gremlin ПРИ altlinux ТЧК org; +vii-cmiii-ccxxix-lxxix-xlii
GPG: 0D92F19E1C0DC36E27F61A29CD17E2B43D879005 @ hkp://keys.gnupg.net
