On 2022-12-16 09:21, Bjorn Helgaas wrote: > From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > > switchtec_dev_read() didn't handle copy_to_user() errors correctly: it > assigned "rc = -EFAULT", but actually returned either "size", -ENXIO, or > -EBADMSG instead. > > Update the failure cases to unlock mrpc_mutex and return -EFAULT directly. > > Fixes: 080b47def5e5 ("MicroSemi Switchtec management interface driver") > Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> Looks good to me thanks! Reviewed-by: Logan Gunthorpe <logang@xxxxxxxxxxxx> Logan